Re: flexfax: faxcron error

[Darren Nickerson <darren@hylafax.org>]

>>>>> On Wed, 31 May 2000, "Lee" == Lee Howard wrote:

  Lee> I'm wondering why faxcron-dirs.patch didn't get applied to beta1 or
  Lee> beta2.  No matter, it can be applied to an already-compiled installation
  Lee> since faxcron is not binary.


That patch was applied to the current HylaFAX CVS on March 29 of this year. At 
least some of it was . . . *grunt* there, I just applied the rest of it. So 
it's all in beta3 now, promise.

See:

http://www.hylafax.org/cgi-bin/cvsweb.cgi/util/faxcron.sh.in?hideattic=1&sortby
date=0

for the history

http://www.hylafax.org/cgi-bin/cvsweb.cgi/util/faxcron.sh.in.diff?r1=1.5&r2=1.6
&hideattic=1&sortbydate=0&f=h

for the changes I just made, and

http://www.hylafax.org/cgi-bin/cvsweb.cgi/util/faxcron.sh.in.diff?hideattic=1&r
1=1.4%3AHYLAFAX-4_1BETA1&tr1=1.1.1.1&r2=text&tr2=1.6&f=u

for a patch that you should be apply to apply to your 4.1beta1 script. 

Looking at it, faxcron.sh.in is in a bit of a state at the moment, with two 
patches fighting over one another :-( I've included the original messages at 
the end of this one, and added their authors to the cc: list.

I only have time to highlight the problem. If you think you have the solution, 
join hylafax-devel@hylafax.org and/or submit your patch to patches@hylafax.org.

-Darren

---

• To: flexfax@sgi.com
• Subject: flexfax: possible bug in faxcron
• From: Seth Chaiklin <seth@pc126.psy.aau.dk>
• Date: Fri, 20 Mar 1998 17:20:27 +0100

Faxcron is supposed to return the associated trace log of any calls
that failed suspiciously.

It never worked for me.  

I looked into why and found this answer:

If I modified the awk script in faxcron script as follows:
making the failures have a first letter capital (as they do in 
the etc/xferlog), then it worked fine.

I use:  Gnu Awk (gawk) 3.0, patchlevel 0

I am curious if anyone can confirm, deny , or clarify.

Thanks,
  Seth Chaiklin

Here is a small patch.

--- faxcron.sh.in.orig	Fri Mar 20 12:32:44 1998
+++ faxcron.sh.in	Fri Mar 20 16:15:10 1998
@@ -229,14 +233,14 @@
 }
 
 BEGIN		{ FS="\t";
-		  callFailed["busy signal"] = 1;
-		  callFailed["unknown pro"] = 1;
-		  callFailed["no carrier "] = 1;
-		  callFailed["no local di"] = 1;
-		  callFailed["no answer f"] = 1;
-		  callFailed["job aborted"] = 1;
-		  callFailed["invalid dia"] = 1;
-		  callFailed["can not loc"] = 1;
+		  callFailed["Busy signal"] = 1;
+		  callFailed["Unknown pro"] = 1;
+		  callFailed["No carrier "] = 1;
+		  callFailed["No local di"] = 1;
+		  callFailed["No answer f"] = 1;
+		  callFailed["Job aborted"] = 1;
+		  callFailed["Invalid dia"] = 1;
+		  callFailed["Can not loc"] = 1;
 		  months["01"] = "Jan"; months["02"] = "Feb";
 		  months["03"] = "Mar"; months["04"] = "Apr";
 		  months["05"] = "May"; months["06"] = "Jun";

---

---

• To: "HylaFAX Mailing List" <flexfax@sgi.com>
• Subject: flexfax: small bug in faxcron script (beta-rjc10)
• From: "Alan Sparks" <asparks@cpd.harris.com>
• Date: Fri, 25 Jun 1999 09:07:15 -0700

I'm getting "no carrier" and "busy signal" reports from faxcron.  There's
code to filter it, but a change to the message list keeps it from working.

Lines 232-239 of faxcron are of the form:
                  callFailed["Busy signal"] = 1;
                  callFailed["Unknown pro"] = 1;
                  callFailed["No carrier "] = 1;

These are capitalized in this version.  Unfortunately, in function 'acct',
the xferlog message is run through 'tolower' so won't match.

These callFailed[] entries need to be converted back to all lowercase.
-Alan

=============
Alan Sparks, UNIX Network Administrator           <asparks@cpd.harris.com>
Harris Communications, Camarillo CA                   (805) 389-2430

---