Re: flexfax: faxcron deletes seqf files

[Peter Stamfest <peter.stamfest@eunet.at>]

On Mon, 8 May 2000, Tim Rice wrote:

> On Mon, 8 May 2000, Peter Stamfest wrote:
> 
> > On Mon, 8 May 2000, Tim Rice wrote:
> > 
> > > On Sun, 7 May 2000, Peter Stamfest wrote:
> > > 
> > > > 
> > > > Hi,
> > > > 
> > > > It seems to me that the faxcron cronjob coming with hylafax 4.1beta1
> > > > deletes the seqf file in the receive queue, if no faxes have been
> > > > received during the AGERCV period. The same is true for the log
> > > > seqf file.
> > > > 
> > > > Without having gone into the very very details of hylafax operation, I
> > > > would think that this is not wanted. 
> > > > 
> > > > In reality, this might cause problems if faxes are automatically
> > > > transferred to some storage area not under hylafax control. The lost seqf
> > > > file would then lead to doubly generated filenames. 
> > > > 
> > > > Find a patch to 4.1beta2 [the same bug (?) exists in 4.1beta1] attached.
> > > > 
> > > 
> > > Good call, but your patch is not portable.
> > > 
> > > 	find log -not -name seqf -type f -mtime +$AGELOG -print >$JUNK
> > >                  ^^^^
> > > try
> > > 	find log ! -name seqf -type f -mtime +$AGELOG -print >$JUNK
> > > > 
> > 
> > You are right, I'm too GNUish, I guess. I'm not used to the exclamation
> > mark as it has a special meaning in bash...
> > 
> > The buglet, however, remains. 
> > 
> > I guess the finding itself should be incorporated into the source
> > distribution. Where should I mail a modified patch to?
> 
> Just send it to the list. It will get picked up by those
> that have write access to the CVS sources.
> 

OK, find the modified patch attached. It applies cleanly to 4.1beta[12].

peter

> -- 
> Tim Rice				Multitalents	(707) 874-1130
> tim@trr.metro.net
> 

*** hylafax-4.1beta2/util/faxcron.sh.in	Tue Jun 29 13:55:07 1999
--- hylafax-4.1beta2/util/faxcron.sh.in-fixed	Sun May  7 16:03:02 2000
***************
*** 324,328 ****
  echo ""
  
! find log -mtime +$AGELOG -print >$JUNK
  if [ -s $JUNK ]; then
      echo "Purge session logs older than $AGELOG days:"
--- 324,328 ----
  echo ""
  
! find log ! -name seqf -type f -mtime +$AGELOG -print >$JUNK
  if [ -s $JUNK ]; then
      echo "Purge session logs older than $AGELOG days:"
***************
*** 404,408 ****
  # Purge old stuff from the receive queue.
  #
! find recvq -mtime +$AGERCV -print >$JUNK
  if [ -s $JUNK ]; then
      echo "Purge received facsimile older than $AGERCV days:"
--- 404,408 ----
  # Purge old stuff from the receive queue.
  #
! find recvq ! -name seqf -type f -mtime +$AGERCV -print >$JUNK
  if [ -s $JUNK ]; then
      echo "Purge received facsimile older than $AGERCV days:"