Re: [hylafax-users] hylafax faxcron bug with origin-1 substr (also, --lint suggestion)

[Darren Nickerson <darren@dazza.org>]

>>>>> On Thu, 20 Jul 2000, "Paul" == Paul Eggert wrote:

  Paul> Here's a patch for a typo in util/faxcron.sh.in.  The code assumes
  Paul> that awk substr is origin-0, but it's really origin-1.  Most awk
  Paul> implementations silently convert the 0 to a 1, but mawk doesn't.

Applied - thanks (see attached message).

  Paul> Suggestion: Hylafax 'configure' could configure Hylfax to use "$AWK
  Paul> --lint" if it detects that the awk implementation is gawk.  That would
  Paul> help catch typos like this.  This could be done by using a new AWKOPTS
  Paul> variable that is '--lint' if --lint works, and empty otherwise.

Send patch against current CVS ;-)

-D

---

• To: hyla-cvs@sinkhole.tpc.int
• Subject: [hylafax-devel] 'hylafax/util' update now available
• From: Darren Nickerson <darren@sinkhole.tpc.int>
• Date: Fri, 21 Jul 2000 07:18:13 -0700

Update of /usr/local/cvsroot/hylafax/util
In directory sinkhole.tpc.int:/tmp/cvs-serv3079/util

Modified Files:
	faxcron.sh.in 
Log Message:
Correct awk substr to be explicitly origin-1 (rather than origin-0 which gets
silently converted to a 1 in most implementations). Contributed by 
Paul Eggert <eggert@twinsun.com>.



____________________ HylaFAX(tm) Developers Mailing List ____________________
 To unsub: mail -s unsubscribe hylafax-devel-request@hylafax.org < /dev/null

---